--- lbbs/src/net_server.c 2025/05/12 03:54:14 1.25 +++ lbbs/src/net_server.c 2025/05/13 11:35:17 1.32 @@ -35,8 +35,7 @@ #include #include #include - -#define MAX_EVENTS 10 +#include int net_server(const char *hostaddr, in_port_t port) { @@ -46,16 +45,15 @@ int net_server(const char *hostaddr, in_ struct sockaddr_in sin; struct epoll_event ev, events[MAX_EVENTS]; int nfds, epollfd; - sigset_t nsigset; - sigset_t osigset; siginfo_t siginfo; + int sd_notify_stopping = 0; socket_server = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); if (socket_server < 0) { log_error("Create socket failed\n"); - exit(1); + return -1; } sin.sin_family = AF_INET; @@ -77,13 +75,13 @@ int net_server(const char *hostaddr, in_ { log_error("Bind address %s:%u failed (%d)\n", inet_ntoa(sin.sin_addr), ntohs(sin.sin_port), errno); - exit(2); + return -1; } if (listen(socket_server, 10) < 0) { log_error("Socket listen failed (%d)\n", errno); - exit(3); + return -1; } strncpy(hostaddr_server, inet_ntoa(sin.sin_addr), sizeof(hostaddr_server) - 1); @@ -94,11 +92,6 @@ int net_server(const char *hostaddr, in_ log_std("Listening at %s:%d\n", hostaddr_server, port_server); - sigemptyset(&nsigset); - sigaddset(&nsigset, SIGHUP); - sigaddset(&nsigset, SIGCHLD); - sigaddset(&nsigset, SIGTERM); - epollfd = epoll_create1(0); if (epollfd < 0) { @@ -111,28 +104,44 @@ int net_server(const char *hostaddr, in_ if (epoll_ctl(epollfd, EPOLL_CTL_ADD, socket_server, &ev) == -1) { log_error("epoll_ctl(socket_server) error (%d)\n", errno); + if (close(epollfd) < 0) + { + log_error("close(epoll) error (%d)\n"); + } return -1; } flags = fcntl(socket_server, F_GETFL, 0); fcntl(socket_server, F_SETFL, flags | O_NONBLOCK); + // Startup complete + sd_notifyf(0, "READY=1\n" + "STATUS=Listening at %s:%d\n" + "MAINPID=%d", + hostaddr_server, port_server, getpid()); + while (!SYS_server_exit || SYS_child_process_count > 0) { - sigprocmask(SIG_BLOCK, &nsigset, &osigset); - + if (SYS_server_exit && !sd_notify_stopping) + { + sd_notify(0, "STOPPING=1"); + sd_notify_stopping = 1; + } while ((SYS_child_exit || SYS_server_exit) && SYS_child_process_count > 0) { + SYS_child_exit = 0; + siginfo.si_pid = 0; ret = waitid(P_ALL, 0, &siginfo, WEXITED | WNOHANG); if (ret == 0 && siginfo.si_pid > 0) { + SYS_child_exit = 1; // Retry waitid + SYS_child_process_count--; log_std("Child process (%d) exited\n", siginfo.si_pid); } else if (ret == 0) { - SYS_child_exit = 0; break; } else if (ret < 0) @@ -149,10 +158,14 @@ int net_server(const char *hostaddr, in_ { log_error("Send SIGTERM signal failed (%d)\n", errno); } + + sd_notifyf(0, "STATUS=Waiting for %d child process to exit", SYS_child_process_count); } if (SYS_menu_reload && !SYS_server_exit) { + SYS_menu_reload = 0; + if (reload_menu(&bbs_menu) < 0) { log_error("Reload menu failed\n"); @@ -161,11 +174,8 @@ int net_server(const char *hostaddr, in_ { log_std("Reload menu successfully\n"); } - SYS_menu_reload = 0; } - sigprocmask(SIG_SETMASK, &osigset, NULL); - nfds = epoll_wait(epollfd, events, MAX_EVENTS, 100); // 0.1 second if (nfds < 0) @@ -188,16 +198,24 @@ int net_server(const char *hostaddr, in_ { if (events[i].data.fd == socket_server) { - while (1) // Accept all incoming connections until error + while (!SYS_server_exit) // Accept all incoming connections until error { socket_client = accept(socket_server, (struct sockaddr *)&sin, &namelen); if (socket_client < 0) { - if (errno != EAGAIN && errno != EWOULDBLOCK && errno != ECONNABORTED && errno != EINTR) + if (errno == EAGAIN || errno == EWOULDBLOCK) + { + break; + } + else if (errno == EINTR) + { + continue; + } + else { log_error("accept(socket_server) error (%d)\n", errno); + break; } - break; } strncpy(hostaddr_client, inet_ntoa(sin.sin_addr), sizeof(hostaddr_client) - 1); @@ -221,6 +239,11 @@ int net_server(const char *hostaddr, in_ } } + if (close(epollfd) < 0) + { + log_error("close(epoll) error (%d)\n"); + } + fcntl(socket_server, F_SETFL, flags); if (close(socket_server) == -1)