--- lbbs/src/menu.c 2025/05/15 09:15:52 1.43 +++ lbbs/src/menu.c 2025/05/18 08:53:21 1.47 @@ -546,12 +546,8 @@ int load_menu(MENU_SET *p_menu_set, cons log_error("Error menu screen name in menu config line %d\n", fin_line); return -1; } - if (trie_dict_get(p_menu_set->p_menu_screen_dict, p, (int64_t *)&screen_id) != 1) - { - log_error("Undefined menu screen [%s]\n", p); - return -1; - } - p_menu->screen_id = screen_id; + strncpy(p_menu->screen_name, p, sizeof(p_menu->screen_name) - 1); + p_menu->screen_name[sizeof(p_menu->screen_name) - 1] = '\0'; // Check syntax q = strtok_r(NULL, MENU_CONF_DELIM_WITH_SPACE, &saveptr); @@ -628,6 +624,14 @@ int load_menu(MENU_SET *p_menu_set, cons break; } + // Clear line + if (p_menu_set->p_menu_screen_buf_free + strlen(CTRL_SEQ_CLR_LINE) > q) + { + log_error("Menu screen buffer depleted (%p + %d > %p)\n", p_menu_set->p_menu_screen_buf_free, q, strlen(CTRL_SEQ_CLR_LINE)); + return -3; + } + p_menu_set->p_menu_screen_buf_free = stpcpy(p_menu_set->p_menu_screen_buf_free, CTRL_SEQ_CLR_LINE); + p = buffer; while (*p != '\0') { @@ -663,11 +667,32 @@ int load_menu(MENU_SET *p_menu_set, cons } fclose(fin); - // Set menu_item->action_menu_id of each menu item pointing to a submenu to the menu_id of the corresponding submenu + for (menu_id = 0; menu_id < p_menu_set->menu_count; menu_id++) + { + p_menu = get_menu_by_id(p_menu_set, menu_id); + + if (trie_dict_get(p_menu_set->p_menu_screen_dict, p_menu->screen_name, (int64_t *)(&(p_menu->screen_id))) != 1) + { + log_error("Undefined menu screen [%s]\n", p); + return -1; + } + } + for (menu_item_id = 0; menu_item_id < p_menu_set->menu_item_count; menu_item_id++) { p_menu_item = get_menu_item_by_id(p_menu_set, menu_item_id); - if (p_menu_item->submenu == 1 && strcmp(p_menu_item->action, "..") != 0) + + // Set menu_item->action_cmd_handler of each menu item pointing to bbs_cmd + if (p_menu_item->submenu == 0) + { + if ((p_menu_item->action_cmd_handler = get_cmd_handler(p_menu_item->action)) == NULL) + { + log_error("Undefined menu action cmd handler [%s]\n", p_menu_item->action); + return -1; + } + } + // Set menu_item->action_menu_id of each menu item pointing to a submenu to the menu_id of the corresponding submenu + else if (strcmp(p_menu_item->action, "..") != 0) { if (trie_dict_get(p_menu_set->p_menu_name_dict, p_menu_item->action, (int64_t *)&menu_id) != 1) { @@ -880,7 +905,7 @@ int menu_control(MENU_SET *p_menu_set, i } else { - return (exec_cmd(p_menu_item->action, p_menu_item->name)); + return ((*(p_menu_item->action_cmd_handler))((void *)(p_menu_item->name))); } break; case KEY_LEFT: @@ -1063,18 +1088,16 @@ int unload_menu(MENU_SET *p_menu_set) int load_menu_shm(MENU_SET *p_menu_set) { // Mount shared memory - if (p_menu_set->p_reserved != NULL) + if (p_menu_set->p_reserved == NULL) { - log_error("Menu is already loaded\n"); - return -1; + p_menu_set->p_reserved = shmat(p_menu_set->shmid, NULL, SHM_RDONLY); + if (p_menu_set->p_reserved == (void *)-1) + { + log_error("shmat() error (%d)\n", errno); + return -1; + } } - p_menu_set->p_reserved = shmat(p_menu_set->shmid, NULL, SHM_RDONLY); - if (p_menu_set->p_reserved == (void *)-1) - { - log_error("shmat() error (%d)\n", errno); - return -2; - } p_menu_set->p_menu_pool = p_menu_set->p_reserved + MENU_SET_RESERVED_LENGTH; p_menu_set->p_menu_item_pool = p_menu_set->p_menu_pool + sizeof(MENU) * MAX_MENUS; p_menu_set->p_menu_screen_pool = p_menu_set->p_menu_item_pool + sizeof(MENU_ITEM) * MAX_MENUITEMS;