--- fenglin/bbs/reg_user_service.php 2025/03/31 14:13:22 1.1 +++ fenglin/bbs/reg_user_service.php 2025/04/01 12:18:40 1.2 @@ -145,6 +145,10 @@ exit(json_encode($result_set)); } + // Secure SQL statement + $nickname = mysqli_real_escape_string($db_conn, $nickname); + $realname = mysqli_real_escape_string($db_conn, $realname); + // Begin transaction $rs = mysqli_query($db_conn, "SET autocommit=0"); if ($rs == false) @@ -167,8 +171,7 @@ } // Check availability of username and nickname - $sql = "SELECT UID FROM user_list WHERE username = '" . - mysqli_real_escape_string($db_conn, $username) . "'"; + $sql = "SELECT UID FROM user_list WHERE username = '$username'"; $rs = mysqli_query($db_conn, $sql); if ($rs == false) @@ -190,8 +193,7 @@ } mysqli_free_result($rs); - $sql = "SELECT UID FROM user_nickname WHERE nickname = '" . - mysqli_real_escape_string($db_conn, $nickname) . "'"; + $sql = "SELECT UID FROM user_nickname WHERE nickname = '$nickname'"; $rs = mysqli_query($db_conn, $sql); if ($rs == false) @@ -213,8 +215,7 @@ } mysqli_free_result($rs); - $sql = "SELECT UID FROM user_pubinfo WHERE email = '" . - mysqli_real_escape_string($db_conn, $email) . "'"; + $sql = "SELECT UID FROM user_pubinfo WHERE email = '$email'"; $rs = mysqli_query($db_conn, $sql); if ($rs == false) @@ -259,8 +260,8 @@ $uid = mysqli_insert_id($db_conn); - $sql = "INSERT INTO user_reginfo(UID, name, birthday, signup_dt, signup_ip) VALUES($uid, '" . - mysqli_real_escape_string($db_conn, $realname) . "', '$year-$month-$day', NOW(), '". + $sql = "INSERT INTO user_reginfo(UID, name, birthday, signup_dt, signup_ip) + VALUES($uid, '$realname', '$year-$month-$day', NOW(), '". client_addr() . "')"; $rs = mysqli_query($db_conn, $sql); @@ -273,8 +274,8 @@ exit(json_encode($result_set)); } - $sql = "INSERT INTO user_pubinfo(UID, nickname, email, gender, gender_pub, qq, last_login_dt) VALUES($uid, '" . - mysqli_real_escape_string($db_conn, $nickname) . "', '$email', '$gender', $gender_public, '$qq', NOW())"; + $sql = "INSERT INTO user_pubinfo(UID, nickname, email, gender, gender_pub, qq, last_login_dt) + VALUES($uid, '$nickname', '$email', '$gender', $gender_public, '$qq', NOW())"; $rs = mysqli_query($db_conn, $sql); if ($rs == false) @@ -286,8 +287,8 @@ exit(json_encode($result_set)); } - $sql = "INSERT INTO user_nickname(UID, nickname, begin_dt, begin_reason) VALUES($uid, '" . - mysqli_real_escape_string($db_conn, $nickname) . "', NOW(), 'R')"; + $sql = "INSERT INTO user_nickname(UID, nickname, begin_dt, begin_reason) + VALUES($uid, '$nickname', NOW(), 'R')"; $rs = mysqli_query($db_conn, $sql); if ($rs == false)