--- fenglin/bbs/common_lib.inc.php	2004/09/17 14:57:29	1.1
+++ fenglin/bbs/common_lib.inc.php	2025/04/13 05:06:58	1.7
@@ -1,13 +1,12 @@
 <?
-
-//Function article_op_log()
 //Log article operation into table bbs_article_log
-function article_op_log($aid,$uid,$op_type,$ip_addr,$db_conn=null)
+function article_op_log(int $aid, int $uid, string $op_type, string $ip_addr, mysqli $db_conn = null) : mysqli_result | bool
 {
 	/*
 		Type	Description
 		A		Add article
 		D		Delete article
+		X		Delete article by Admin
 		S		Restore article
 		L		Lock article
 		U		Unlock article
@@ -17,34 +16,32 @@ function article_op_log($aid,$uid,$op_ty
 		O		Unset article as excerption
 		F		Set article on top
 		V		Unset article on top
-		R		Recommend article
-		N		Unrecommend article
 		Z		Set article as trnasship
 	*/
-	$ret = mysql_query("insert delayed into bbs_article_op(AID,UID,type,op_dt,op_ip)".
-		" values($aid,$uid,'$op_type',now(),'$ip_addr')",$db_conn);
-	
+
+	$sql = "INSERT INTO bbs_article_op(AID, UID, type, op_dt, op_ip)
+			VALUES($aid, $uid, '$op_type', NOW(), '$ip_addr')";
+
+	$ret = mysqli_query($db_conn, $sql);
+
 	return $ret;
 }
 
-
-//Function user_exp_change()
 //Add/Subtract user exp
-function user_exp_change($uid,$exp_change,$db_conn=null)
+function user_exp_change(int $uid, int $exp_change, mysqli $db_conn = null) : mysqli_result | bool
 {
-	$ret = mysql_query("update user_pubinfo set exp=exp+$exp_change".
-		" where UID=".$uid);
+	$sql = "UPDATE user_pubinfo SET exp = exp + $exp_change WHERE UID = $uid";
+
+	$ret = mysqli_query($db_conn, $sql);
 
 	return $ret;
 }
 
-
-//Function error_msg()
 //Display error message in a pop-up window
-function error_msg($msg,$back=false,$close=false)
+function error_msg($msg, $back=false, $close=false)
 {
 	$ret = "<script language=\"JavaScript\">\n".
-		"	alert(\"".$msg."\");\n".
+		"	alert(\"".str_replace("\n","\\\n",$msg)."\");\n".
 		($back?"	history.go(-1);\n":"").
 		($close?"	self.close();\n":"").
 		"</script>";